After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744586 - Corrupted documents can crash evince
Corrupted documents can crash evince
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-16 10:34 UTC by Marek Kašík
Modified: 2015-10-19 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check for failed rendering jobs (4.23 KB, patch)
2015-02-16 10:34 UTC, Marek Kašík 		none Details | Review

Description Marek Kašík 2015-02-16 10:34:23 UTC 
Created attachment 296912 [details] [review]
Check for failed rendering jobs

I've got some downstream reports about crashes of evince on corrupted document files. See
https://bugzilla.redhat.com/show_bug.cgi?id=1190174,
https://bugzilla.redhat.com/show_bug.cgi?id=1187182 and
https://bugzilla.redhat.com/show_bug.cgi?id=1175915.

These crashes happens because of a wrong PostScript file. It loads but it
doesn't render correctly. Evince then crashes because of unhandled checks for
failed rendering jobs of sidebar thumbnails, recent view thumbnails and the
document itself.

There is a good reproducer described here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767234.

Attached patch fixes these crashes for me. Although evince still shows that
the document is still loading (this happens because of draw_one_page() calls
"ev_view_set_loading (view, TRUE)" if "!page_surface" which satisfies also the
case when the rendering failed not just when the document is still loading).
Comment 1 Michael Catanzaro 2015-09-02 16:49:47 UTC 
This is the other patch we have in Fedora.
Comment 2 Carlos Garcia Campos 2015-10-16 11:42:29 UTC 
I reviewed this patch in bug #744049, feel free to push anyway.
Comment 4 Marek Kašík 2015-10-16 13:31:11 UTC 
Maybe we should wait until a gnome-3-18 branch is created so we don't push new translatable strings into stable releases.
Comment 5 Carlos Garcia Campos 2015-10-16 13:58:50 UTC 
(In reply to Marek Kašík from comment #4)
> Maybe we should wait until a gnome-3-18 branch is created so we don't push
> new translatable strings into stable releases.

Indeed, I haven't branched yet.
Comment 6 Carlos Garcia Campos 2015-10-18 08:36:29 UTC 
Actually, those translatable strings are messages that never reach the UI nor even stdout/stderr, it's an internal error, so I think we can just keep those strings in English.
Comment 7 Carlos Garcia Campos 2015-10-18 08:38:43 UTC 
Ah, never mind, those could be used by libview users. . . Another reason to use a better Quark
Comment 8 Carlos Garcia Campos 2015-10-18 08:43:49 UTC 
I've just created the gnome-3-18 branch right before this commit.
Comment 9 Marek Kašík 2015-10-19 08:38:41 UTC 
(In reply to Carlos Garcia Campos from comment #8)
> I've just created the gnome-3-18 branch right before this commit.

Thank you for fixing this.