GNOME Bugzilla – Bug 744541
No plural use in KMail importer
Last modified: 2015-02-17 13:54:16 UTC
Hi, in the KMail importer it looks strange to me that plural forms never are used, or is it just possible to import one address or contact from KMail? In /mail/importers/kmail-importer.c is the string "%d Address", where %d is the length of a contact list. This will look strange for lists longer than 1. If the list can be longer than 1 it should use "%d Addresses" for plural forms in those cases, and "%d Address" just when %d=1. A related question is two strings in /mail/importers/mail-importer.c and /mail/importers/kmail-importer.c: "Importing mail and contact from KMail" and "Import mail and contact from KMail." These strings look to me as if it just imports a single contact from KMail. If it is possible to import multiple contacts it should say "contacts" instead, or possibly "contact(s)" if one wishes to be more vague over whether it is one or several contacts. Regards, Anders Jonsson
Created attachment 296871 [details] [review] plural message hi Anders, Thank you, the patch solves the previous mistakes. David
(In reply to David Liang from comment #1) > Created attachment 296871 [details] [review] [review] > plural message > > hi Anders, > Thank you, the patch solves the previous mistakes. > > David Thank you, that looks much better. However, I'm not certain that the (s) in mail(s) is needed. Mail is listed as an uncountable noun on http://www.oxfordlearnersdictionaries.com/definition/english/mail_1?q=mail A look in Windows Mail and Thunderbird show that they just write "Import mail", and in Evolution there exists the older strings "Import mail from Elm." and "Import mail from Pine.".
Thanks for a bug report and patch. Let's have it "Importing mail and contacts from KMail", whether there is none or one or many contacts is irrelevant in the time when the message is shown and used, it just gives an idea what kind of data will be imported. Created commit 160d8e4 in evo master (3.13.91+)