highcontrast theme is now part of gtk

(In reply to Arnaud Bonatti from comment #0)
> Using HighContrast theme, buttons with the “flat” class do not “change
> color” (be grayed) when insensitive.

Can you provide an example app that uses the style? The flat style buttons do have an inssensitive style defined as can be seen in the gtk3-widget-factory screenshot attached (the file open vertical toolbar button on page 3).

Created attachment 296969 [details]
screenshot of a flat insensitive button in HC theme

You can test it in Klotski (`gnome-klotski`) master (beginnig with 3.15.90): in the “Change Puzzle” popover, the two arrows that permit to change the level pack are flat.

When the window is at the top, the two buttons are black, whatever pack you’re playing with (the left arrow should be grayed on first pack, and the right one on last/third pack).

When the window isn’t at the top (:backdrop in CSS), the insensitive arrows are drawn with the good color but with a non-flat design.

Oh, always with flat HighContrast buttons: when :active, they are written black on black. They should at least be written white on black, like the “Change Grid” menubutton of Klotski, or more greyish like the two headerbar’s togglebuttons of Polari (why this difference?).

I think this is fixed. not seeing button problems with hc in gtk3-widget-factory anymore.

I reopen, as Klotski’s bug isn’t solved. Looks like the general case is now correctly handled, but –don’t know why– buttons in popovers are special-cased[1].

[1] https://git.gnome.org/browse/gtk+/tree/gtk/theme/HighContrast/gtk.css#n1287

Note: I currently have a strange theme error[1] launching every application in HighContrast theme, but I assume it’s not related.

[1] GtkWarning **: Theme parsing error: HighContrast.css:2545:58: '_widget_edge' is not a valid color name
GtkWarning **: Theme parsing error: HighContrast.css:2545:60: '_widget_edge' is not a valid color name
GtkWarning **: Theme parsing error: HighContrast.css:2545:62: '_widget_edge' is not a valid color name

Arnaud has added CSS to Klotski as a workaround for this issue.

Closing as Klotski case seems to be solved.