After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744501 - Valencia wants Gedit.Panel and Gedit.Encoding
Valencia wants Gedit.Panel and Gedit.Encoding
Status: RESOLVED DUPLICATE of bug 724173
Product: valencia
Classification: Other
Component: general
0.8.x
Other Linux
: Normal normal
: ---
Assigned To: Valencia Maintainers
Valencia Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-13 23:25 UTC by Kyrylo V. Polezhaiev
Modified: 2015-02-13 23:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kyrylo V. Polezhaiev 2015-02-13 23:25:12 UTC
When I try to compile Valencia from it's sources, it fails to build cause it seems there is no Gedit.Panel anymore.
Comment 1 Kyrylo V. Polezhaiev 2015-02-13 23:27:39 UTC
valac  -X --shared -X -fPIC --pkg gedit --pkg gee-0.8 --pkg gtk+-3.0 --pkg gtksourceview-3.0 --pkg libpeas-1.0 --pkg libvala-0.26 --pkg vte-2.90 autocomplete.vala browser.vala expression.vala gtk_util.vala parser.vala program.vala scanner.vala settings.vala util.vala valencia.vala -o libvalencia.so
browser.vala:38.9-38.24: error: The type name `Gedit.Panel' could not be found
        weak Gedit.Panel panel = instance.window.get_side_panel();
        ^^^^^^^^^^^^^^^^
browser.vala:168.9-168.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = instance.window.get_side_panel();
        ^^^^^^^^^^^
valencia.vala:274.9-274.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = window.get_bottom_panel();
        ^^^^^^^^^^^
valencia.vala:649.9-649.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = window.get_bottom_panel();
        ^^^^^^^^^^^
valencia.vala:671.9-671.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = window.get_bottom_panel();
        ^^^^^^^^^^^
valencia.vala:801.9-801.22: error: The type name `Gedit.Encoding' could not be found
        Gedit.Encoding encoding = null;
        ^^^^^^^^^^^^^^
valencia.vala:1280.9-1280.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = window.get_bottom_panel();
        ^^^^^^^^^^^
valencia.vala:1590.9-1590.19: error: The type name `Gedit.Panel' could not be found
        Gedit.Panel panel = window.get_bottom_panel();
        ^^^^^^^^^^^
Compilation failed: 8 error(s), 0 warning(s)
Makefile:59: recipe for target 'libvalencia.so' failed
make: *** [libvalencia.so] Error 1
Comment 2 Kyrylo V. Polezhaiev 2015-02-13 23:33:12 UTC
It seems we should replace GeditPanel with GeditStack just like here: https://mail.gnome.org/archives/commits-list/2014-February/msg06893.html
Comment 3 Jim Nelson 2015-02-13 23:46:38 UTC
There's a work-in-progress branch, as described in bug #724173.  If you're interested in working on it, we're looking for help!

*** This bug has been marked as a duplicate of bug 724173 ***
Comment 4 Kyrylo V. Polezhaiev 2015-02-13 23:55:22 UTC
Oh, I am so sorry I didn't note your branch.
Yep, I am interested working on it.
Comment 5 Jim Nelson 2015-02-13 23:57:10 UTC
Feel free to submit a patch on that ticket!  Every bit counts.