GNOME Bugzilla – Bug 744465
install-plugins: add _set_desktop_id(), _set_startup_notification_id() and _set_confirm_search() API
Last modified: 2015-02-15 16:54:54 UTC
I've been looking into making missing gstreamer plugin installation work with gnome-software. Currently, the missing plugin installation API is rather limited and only supports passing the XID of the app's window and no other details. The way this was used was that gnome-packagekit would use the app's window XID to to attach its own window as a transient child to the app's window. In gnome-software, we would like to avoid doing that for a number of reasons, most of all because it can't work under Wayland. I'd like to add some replacement missing plugin API to make it work without replying on the window XID. Attaching two patches for that.
Created attachment 296772 [details] [review] install-plugins: Add API for passing desktop ID and startup ID The new gst_install_plugins_context_set_desktop_id() and gst_install_plugins_context_set_startup_notification_id() API can be used to pass extra details to the external installer process.
Created attachment 296773 [details] [review] install-plugins: Add API to suppress confirmation before searching The new gst_install_plugins_context_set_confirm_search() API can be used to pass a hint to modify the behaviour of the external installer process.
Thanks, that looks fine, pushed to master with minor changes (added "Since: 1.6" gtk-doc markers and ran gst-indent on the .c files): commit 25abb5fd4d31cf8568bb4c650971bbc566a63e24 Author: Tim-Philipp Müller <tim@centricular.com> Date: Fri Feb 13 22:49:04 2015 +0000 install-plugins: add new API to exports .def and to docs https://bugzilla.gnome.org/show_bug.cgi?id=744465 commit 4d8f52eeef81a4b44af36d007dbeda157c5cec3f Author: Kalev Lember <kalevlember@gmail.com> Date: Tue Feb 3 10:47:11 2015 +0100 install-plugins: Add API to suppress confirmation before searching The new gst_install_plugins_context_set_confirm_search() API can be used to pass a hint to modify the behaviour of the external installer process. https://bugzilla.gnome.org/show_bug.cgi?id=744465 commit 538dc374c6899ae243831f134af2dbe9487bb48d Author: Kalev Lember <kalevlember@gmail.com> Date: Mon Feb 2 16:16:46 2015 +0100 install-plugins: Add API for passing desktop ID and startup ID The new gst_install_plugins_context_set_desktop_id() and gst_install_plugins_context_set_startup_notification_id() API can be used to pass extra details to the external installer process. https://bugzilla.gnome.org/show_bug.cgi?id=744465 I knew the day would come when we'll be glad we added that extra context thingy :) Not entirely sure about the docs blurbfor gst_install_plugins_context_set_startup_notification_id(): it basically suggests this: startup_id = g_strdup_printf ("_TIME%u", gtk_get_current_event_time ()); which is not what the spec suggests, which has an additional hostname+pid prefix at the beginning, but I suppose it doesn't matter much in practice.
Thanks for getting this in so quickly!