After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744457 - 0001-Drop-use-of-libgsystem-move-single-API-call-into-she.patch
0001-Drop-use-of-libgsystem-move-single-API-call-into-she.patch
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-13 09:31 UTC by Colin Walters
Modified: 2015-02-14 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Drop-use-of-libgsystem-move-single-API-call-into-she.patch (4.24 KB, patch)
2015-02-13 09:31 UTC, Colin Walters 		accepted-commit_now Details | Review
main: Fix structured_log() call (1002 bytes, patch)
2015-02-13 22:18 UTC, Florian Müllner 		none Details | Review

Description Colin Walters 2015-02-13 09:31:10 UTC 
Created attachment 296754 [details] [review]
0001-Drop-use-of-libgsystem-move-single-API-call-into-she.patch

0001-Drop-use-of-libgsystem-move-single-API-call-into-she.patch
Comment 1 Colin Walters 2015-02-13 09:32:53 UTC 
Note: compile tested only; gnome-continuous is a bit broken at runtime at the moment for various reasons, and my interest in trying to coax jhbuild into running (as opposed to building) is very low.
Comment 2 Florian Müllner 2015-02-13 09:57:24 UTC 
Review of attachment 296754 [details] [review]:

::: src/shell-global.c
@@ +1333,3 @@
+    n_opts++; /* Add one for MESSAGE= */
+    iovs = g_alloca (sizeof (struct iovec) * n_opts);
+    

Trailing whitespace here ...

@@ +1342,3 @@
+    iovs[i].iov_base = msgkey;
+    iovs[i].iov_len = strlen (msgkey);
+    

... and here.

Please remove before pushing.
Comment 3 Florian Müllner 2015-02-13 22:18:01 UTC 
The following fix has been pushed:
299ec4f main: Fix structured_log() call
Comment 4 Florian Müllner 2015-02-13 22:18:09 UTC 
Created attachment 296804 [details] [review]
main: Fix structured_log() call

Meh, I should have caught that one in review ...
Comment 5 Colin Walters 2015-02-14 13:53:58 UTC 
Ah, sorry =/  Thanks for fixing it.