GNOME Bugzilla – Bug 744446
duplicate new window actions
Last modified: 2015-06-22 21:02:32 UTC
While fixing gedits desktop file to use the proper gaction id new-window for its new window Desktop Action, I noticed that gnome-shell still shows its own 'New Window' action in the context menu, even when the application has app.new-window. That looks a bit silly in the menu. I would suggest to hide 'New Window' if we find the app.new-window action.
Created attachment 296760 [details] [review] appDisplay: Do not duplicate "New Window" action We assume that applications that export a 'new-window' action can open a new window, so we add an appropriate entry to the context menu. However this duplicates functionality if the application already exposes the action via the desktop file - don't add our own entry in that case.
Review of attachment 296760 [details] [review]: lgtm
Attachment 296760 [details] pushed as 12cb023 - appDisplay: Do not duplicate "New Window" action
The Midori web browser has a 'WindowNew' desktop action with the text 'New Window'. The fix doesn't work for that case, the context menu still shows 'New Window' twice.
(In reply to Ron Yorston from comment #4) > The fix doesn't work for that case That's because we make no intend to guess if an arbitrary action will open a new window - if we assume that the app can create a new window and doesn't export an action called 'new-window' (not 'NewWindow', 'open-window', 'CreateNewWindow', ...), we add the option ourselves.