After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744386 - decklink: incorrect frame rate values for interlaced modes
decklink: incorrect frame rate values for interlaced modes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 745041 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-12 11:28 UTC by d.dedisse
Modified: 2015-03-02 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Incorrect frame rate for interlaced mode patch (1.09 KB, patch)
2015-02-12 12:46 UTC, d.dedisse 		committed Details | Review

Description d.dedisse 2015-02-12 11:28:24 UTC 
in gstdecklink.cpp  
The GstDecklinkMode modes array contains incorrect frame rate values for interlaced modes :


Current : 
160:  {bmdModeHD1080i50, 1920, 1080, 50, 1, true, HD},
161:  {bmdModeHD1080i5994, 1920, 1080, 60000, 1001, true, HD},
162:  {bmdModeHD1080i6000, 1920, 1080, 60, 1, true, HD},


correct values should be :
160:  {bmdModeHD1080i50, 1920, 1080, 25, 1, true, HD },
161:  {bmdModeHD1080i5994, 1920, 1080, 30000, 1001, true, HD },
162:  {bmdModeHD1080i6000, 1920, 1080, 30, 1, true, HD },


tested and verified with a decklink quad
Comment 1 Tim-Philipp Müller 2015-02-12 11:39:58 UTC 
Would be great if you could make a patch in 'git format-patch' format.
Comment 2 d.dedisse 2015-02-12 12:46:32 UTC 
Created attachment 296677 [details] [review]
Incorrect frame rate for interlaced mode patch
Comment 3 Sebastian Dröge (slomo) 2015-02-12 12:49:55 UTC 
Someone else mentioned this in another bug too, but the current values work for me correctly on a Studio 4k.

What's the effect you get with the current values?
Comment 4 d.dedisse 2015-02-16 08:28:24 UTC 
I use the decklkink quad for recording (using DecklinkVideoSrc).
If the SDI input is interlaced, I need to change the values in the array to make it working. Without change not frame are grabbed.
Comment 5 Sebastian Dröge (slomo) 2015-02-16 08:47:08 UTC 
That's unfortunate, as then this code seems to be conditional on the hardware used or maybe also the driver version. I'll test things again when I have access to my hardware again in ~2 weeks.
Comment 6 Sebastian Dröge (slomo) 2015-02-23 18:36:39 UTC 
*** Bug 745041 has been marked as a duplicate of this bug. ***
Comment 7 Sebastian Dröge (slomo) 2015-03-02 11:01:01 UTC 
Thanks for the patch, it's actually looking correct with my hardware and the driver version I have too. Maybe I was just confused last time


commit 034ed48023c6be0eaeb8b4659395a1f35d81f632
Author: DanielD10 <d.dedisse@vogo.fr>
Date:   Thu Feb 12 13:43:30 2015 +0100

    decklink: Incorrect frame rate for interlaced modes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744386