After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744326 - memory leaks at logging
memory leaks at logging
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-11 12:57 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-02-11 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for small memleaks at logging (4.27 KB, patch)
2015-02-11 13:03 UTC, Víctor Manuel Jáquez Leal 		accepted-commit_now Details | Review

Description Víctor Manuel Jáquez Leal 2015-02-11 12:57:50 UTC 
The function gst_caps_to_string () return a new allocated string
that should be free.

Some logging instructions use that function without freeing the
allocated string. This patch replaces the function with
GST_PTR_FORMAT magic, and in the case of the tests, the free()
is added.
Comment 1 Lionel Landwerlin 2015-02-11 13:01:02 UTC 
Did you use git bz and it didn't append the patch? (I've ever git bz needs an update to work with the new bugzilla)
Comment 2 Víctor Manuel Jáquez Leal 2015-02-11 13:02:42 UTC 
(In reply to Lionel Landwerlin from comment #1)
> Did you use git bz and it didn't append the patch? (I've ever git bz needs
> an update to work with the new bugzilla)

Yep. I tried to hacked it but it didn't work. Let me upload the patch.
Comment 3 Víctor Manuel Jáquez Leal 2015-02-11 13:03:42 UTC 
Created attachment 296593 [details] [review]
fix for small memleaks at logging
Comment 4 Lionel Landwerlin 2015-02-11 13:10:25 UTC 
Review of attachment 296593 [details] [review]:

Thanks, please commit to the 3.0 branch.
Comment 5 Víctor Manuel Jáquez Leal 2015-02-11 15:26:47 UTC 
(In reply to Lionel Landwerlin from comment #4)
> Review of attachment 296593 [details] [review] [review]:
> 
> Thanks, please commit to the 3.0 branch.

Done

commit 741781fbb3e533e21084eecf3cb7d7035ce6b3d1
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Wed Feb 11 13:42:54 2015 +0100

    memory leaks at logging
    
    The function gst_caps_to_string () return a new allocated string
    that should be free.
    
    Some logging instructions use that function without freeing the
    allocated string. This patch replaces the function with
    GST_PTR_FORMAT magic, and in the case of the tests, the free()
    is added.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744326