GNOME Bugzilla – Bug 744239
[review] libnm-util, libnm-core: don't define minimum version to be later than maximum
Last modified: 2016-01-20 13:47:16 UTC
Created attachment 296485 [details] libnm-util, libnm-core: don't define minimum version to be later than maximum The networkmanager-openvpn plugin only specifies NM_VERSION_MAX_ALLOWED. Defining the minimum version to NM_VERSION_CUR_STABLE breaks the build when the maximum version is set to 0.9.10. --- libnm-core/nm-version.h.in | 10 +++++----- libnm-util/nm-version.h.in | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-)
Comment on attachment 296485 [details] libnm-util, libnm-core: don't define minimum version to be later than maximum network-manager-applet had the same problem, but I decided that the problem was that it shouldn't have been setting MAX_ALLOWED without setting MIN_REQUIRED, and so updated n-m-a rather than changing NM... We should make sure that our macros work the same way as glib/gtk's do, and then fix whatever needs to be fixed from there.
Fixed it in nm-openvpn then. glib indeed does the same thing.
I think NetworkManager should be fixed, either to handle this situation gracefully, or to return a descriptive error.
Created attachment 300122 [details] [review] temprary fix that I'm using to make things work on my gentoo installation I'm using this patch to make networkmanager-openvpn from portage build with networkmanager from git live ebuild. Attaching in hope it may help someone.
I would like to also note that networkmanager-openvpn 1.0 branch doesn't seem to be fixed and therefore the fix might slip the next maintainance release. https://git.gnome.org/browse/network-manager-openvpn/tree/configure.ac?id=1.0.0#n74
(In reply to Pavel Simerda from comment #5) > I would like to also note that networkmanager-openvpn 1.0 branch doesn't > seem to be fixed and therefore the fix might slip the next maintainance > release. > > https://git.gnome.org/browse/network-manager-openvpn/tree/configure.ac?id=1. > 0.0#n74 fixed openvpn nm-1-0 branch: https://git.gnome.org/browse/network-manager-openvpn/commit/?h=nm-1-0&id=03e404701554c95285a52d947b1a5862cd0af7c5
So are the original patches obsolete, and it should be fixed in consumers of NM's API then? Or are there still outstanding changes to NM?
I don't think there is anything left to do and it's all fixed. Closing BZ now. Please open new a bug.