GNOME Bugzilla – Bug 744125
Nettool uses many deprecated widgets
Last modified: 2021-05-25 11:27:26 UTC
Created attachment 296323 [details] [review] Patch that fixes the ui file and updates the signal handlers Hi, I saw gnome-nettool uses many Gtk(H|V)Box-es, GtkTable-s, Gtk(H|V)ButtonBox-es, that are deprecated, and GtkUIManager that Glade 3.18.x doesn't recognize. I did a patch so that it uses only supported widgets.
Review of attachment 296323 [details] [review]: Please, submit a patch that contains the changes indicated (that it, that does not change in tabs/spaces, which are many).
Created attachment 296366 [details] [review] The same patch without the noise Thank you for your feedback. I have disabled the feature on my editor and I removed the noise by hand, as the command I tried to discard these changes with git did nothing. If there is a command to do this automatically please tell me this command as I'll need to do this for some others patches to. Thank you.
Thanks for the update. I am going to review it later (it is late here). If you run git format-patch, you can use the option: -w, --ignore-all-space Ignore whitespace when comparing lines. This ignores differences even if one line has whitespace where the other line has none.
Hi, Did you forget to review it ? Regards
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-nettool/-/issues/ Thank you for your understanding and your help.