GNOME Bugzilla – Bug 743975
Better deprecation information for GtkStatusIcon
Last modified: 2018-02-17 22:31:32 UTC
"Use notifications" is seriously glib. We should be able to link to a section of example code that would make use of persistent notifications, as an example.
I've added some links to the long description for now. Still need to flesh out the per-function deprecation notes.
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
This is still relevant for GTK+ 3.x. GtkStatusIcon has been removed in GTK+ 4.
Created attachment 368307 [details] [review] docs: Add proper deprecation text for GtkStatusIcon We link to the HowDoI for GNotification in the class description, but we should be more verbose in the deprecation notices for each function of the GtkStatusIcon class.
Review of attachment 368307 [details] [review]: Apart from that one section, it's very good. Thanks! ::: gtk/deprecated/gtkstatusicon.c @@ +2155,3 @@ + * You should, instead, associate one or more actions with the + * #GNotification object, and the platform will invoke the appropriate + * action depending on the user's interaction Is this the right documentation for "set_visible"? I don't understand how it's connected.
Created attachment 368310 [details] [review] docs: Add proper deprecation text for GtkStatusIcon We link to the HowDoI for GNotification in the class description, but we should be more verbose in the deprecation notices for each function of the GtkStatusIcon class.
Review of attachment 368310 [details] [review]: looks good to me