After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743966 - Soup.form_decode crashes gjs in free()
Soup.form_decode crashes gjs in free()
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.53.x
Other Linux
: Normal critical
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-02-04 08:52 UTC by Adrian Negreanu
Modified: 2016-01-15 23:39 UTC
See Also:
GNOME target: ---
GNOME version: 3.15/3.16

Attachments
soup_form_decode*: fix transfer annotation (1.47 KB, patch)
2016-01-15 23:11 UTC, Lionel Landwerlin 		committed Details | Review

Description Adrian Negreanu 2015-02-04 08:52:05 UTC 
I tried to use Soup.form_decode() but it's crashing.

// test.js
var Soup = imports.gi.Soup;
Soup.form_decode("a=b");

then from command line do:
  gjs test.js
Comment 1 Lionel Landwerlin 2016-01-15 23:11:57 UTC 
Created attachment 319160 [details] [review]
soup_form_decode*: fix transfer annotation

The correct transfer annotation to use here is container, as unreffing the
GHashTable will free its items.
Comment 2 Jasper St. Pierre (not reading bugmail) 2016-01-15 23:21:33 UTC 
Review of attachment 319160 [details] [review]:

OK.
Comment 3 Lionel Landwerlin 2016-01-15 23:38:49 UTC 
Review of attachment 319160 [details] [review]:

Pushed to master.