GNOME Bugzilla – Bug 743901
Favorite Playlist and Starring implementation
Last modified: 2015-02-28 15:14:58 UTC
The following patch implements toggle-able stars in the Songs and Playlists views to mark a song as favorite/non. Favorite songs are automatically added to the Favorite Songs playlist. Favorite status is recorded in tracker by means of the `nao:hasTag nao:predefined-tag-favorite` property. ISSUES TO BE RESOLVED: [MediaAudio object].get/set_favourite() methods are currently not working. I've hacked around this by storing the favorite value in [MediaAudio object].get/set_lyrics() (an empty string -- "" -- is False, any non-empty string value is True). (Note that this does not store any data in nmm:lyrics or similar in tracker.) Obviously this vastly un-ideal and hard to read and should be fixed as soon as we can get get/set_favourite() working.
Created attachment 295988 [details] [review] FAVORITES PLAYLIST AND FAVORITE-STARRING
Looks got to me, get/set_lyrics should be replaced after Bug 743922 is fixed
Pushed this as https://git.gnome.org/browse/gnome-music/commit/?id=1c66c49, though I'm gonna keep this open as we still use get_lyrics
get_lyrics() apparently stays for 3.16, closing this one