After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743638 - getting-started: Update example-0.c to use GtkApplication
getting-started: Update example-0.c to use GtkApplication
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-01-28 11:40 UTC by Bastian Ilsø
Modified: 2015-01-28 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update window-default.c, to comply with GtkApplication (1.46 KB, patch)
2015-01-28 11:40 UTC, Bastian Ilsø 		reviewed Details | Review
added "" around org.gtk.example (1.46 KB, patch)
2015-01-28 11:49 UTC, Bastian Ilsø 		committed Details | Review

Description Bastian Ilsø 2015-01-28 11:40:44 UTC 
Created attachment 295641 [details] [review]
update window-default.c, to comply with GtkApplication

https://developer.gnome.org/gtk3/stable/gtk-getting-started.html#id-1.2.3.3

The current basic window example is out of date. This patch changes the example to make it comply with: https://wiki.gnome.org/HowDoI/GtkApplication

The patch needs to be checked for non-common conventions. If the patch is okay, I will update the section's text too.
Comment 1 Cosimo Cecchi 2015-01-28 11:43:11 UTC 
Review of attachment 295641 [details] [review]:

Looks good to me
Comment 2 Emmanuele Bassi (:ebassi) 2015-01-28 11:44:14 UTC 
Review of attachment 295641 [details] [review]:

::: examples/window-default.c
@@ +22,1 @@
+  app = gtk_application_new (org.gtk.example, G_APPLICATION_FLAGS_NONE);

"org.gtk.example" should be a string.
Comment 3 Bastian Ilsø 2015-01-28 11:49:35 UTC 
Created attachment 295643 [details] [review]
added "" around org.gtk.example

fixed, thanks both.