After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743574 - Drop ugly gettext pot file hack in autogen.sh
Drop ugly gettext pot file hack in autogen.sh
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-27 11:24 UTC by David King
Modified: 2015-06-22 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.74 KB, patch)
2015-01-27 11:26 UTC, David King 		none Details | Review
updated patch (2.00 KB, patch)
2015-01-27 17:22 UTC, David King 		committed Details | Review

Description David King 2015-01-27 11:24:51 UTC 
After discussion with desrt at the developer experience hackfest, it seems that it should be possible to remove the ugly hack in autogen.sh, which touches the pot file to give it a really old timestamp. There is a variable provided by gettext for the purposes of ignoring the pot file timestamp, specifically for when using git:

https://www.gnu.org/software/gettext/manual/gettext.html#Translations-under-Version-Control
Comment 1 David King 2015-01-27 11:26:48 UTC 
Created attachment 295519 [details] [review]
proposed patch

The proposed patch seems to work fine for me, but it would be good to know if there are any other reasons why the timestamp hack should be kept.
Comment 2 Javier Jardón (IRC: jjardon) 2015-01-27 17:11:48 UTC 
I guess you will probably want to use DIST_DEPENDS_ON_UPDATE_PO = no as well:

# This tells whether or not to forcibly update $(DOMAIN).pot and
# regenerate PO files on "make dist".  Possible values are "yes" and
# "no".  Set this to no if the POT file and PO files are maintained
# externally.
DIST_DEPENDS_ON_UPDATE_PO = no
Comment 3 David King 2015-01-27 17:22:20 UTC 
Created attachment 295556 [details] [review]
updated patch

Sure, updated to add that variable.
Comment 4 Allison Karlitskaya (desrt) 2015-01-28 10:10:10 UTC 
If this patch ends up putting an up-to-date .pot in the tarball then I think this patch is perfectly correct.  Thanks for some very necessary swamp-draining.
Comment 5 Matthias Clasen 2015-03-02 22:56:56 UTC 
Review of attachment 295556 [details] [review]:

Looks good to me
Comment 7 Colin Walters 2015-06-22 18:44:48 UTC 
http://build.gnome.org/continuous/buildmaster/builds/2015/06/22/51/build/log-gdk-pixbuf.txt

Also worth noting that some older stable distributions like Red Hat Enterprise Linux 7 are on gettext-0.18.2.1-4.el7.x86_64