After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743447 - Fix update when using 'copy' checkout mode
Fix update when using 'copy' checkout mode
Status: RESOLVED OBSOLETE
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-01-24 16:55 UTC by Sylvain Pasche
Modified: 2021-05-17 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix update when using 'copy' checkout mode (2.59 KB, patch)
2015-01-24 16:55 UTC, Sylvain Pasche
none Details | Review

Description Sylvain Pasche 2015-01-24 16:55:34 UTC
I tried to use the 'copy' checkout mode and encountered a few issues with some modules, in particular:

$ jhbuild updateone xwayland
*** Checking out xwayland *** [1/1]
rm -rf /home/spasche/jhbuild/checkout/xwayland
git clone git://anongit.freedesktop.org/git/xorg/xserver xwayland
Cloning into 'xwayland'...
[...]
*** Error during phase checkout of xwayland: Failed to update module (missing .git) (you should check for changes then remove the directory). *** [1/1]

$ jhbuild updateone libmbim
*** Checking out libmbim *** [1/1]
rm -rf /home/spasche/jhbuild/checkout/libmbim
git clone git://anongit.freedesktop.org/libmbim/libmbim.git
Cloning into 'libmbim'...
[...]
cp -R /home/spasche/jhbuild/checkout_copy/libmbim.git /home/spasche/jhbuild/checkout/libmbim.git
cp: cannot stat ‘/home/spasche/jhbuild/checkout_copy/libmbim.git’: No such file or directory
*** Error during phase checkout of libmbim: ########## Error running cp -R /home/spasche/jhbuild/checkout_copy/libmbim.git /home/spasche/jhbuild/checkout/libmbim.git *** [1/1]

The attached patch should fix that.
Comment 1 Sylvain Pasche 2015-01-24 16:55:36 UTC
Created attachment 295337 [details] [review]
Fix update when using 'copy' checkout mode

Use the same logic to compute the checkout directory in get_checkout_dir()
and _copy() when the checkout_mode is 'copy'.
Comment 2 GNOME Infrastructure Team 2021-05-17 16:01:43 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/jhbuild/-/issues/214.