After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743441 - Some GtkListBoxRows have leftover headers
Some GtkListBoxRows have leftover headers
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-24 15:28 UTC by Timm Bäder
Modified: 2015-01-28 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Problem as seen in the sharing panel (with scale=4) (15.78 KB, image/png)
2015-01-24 15:28 UTC, Timm Bäder 		  Details
list-box-helper: Unset row header if unneeded (1.07 KB, patch)
2015-01-24 15:29 UTC, Timm Bäder 		committed Details | Review

Description Timm Bäder 2015-01-24 15:28:57 UTC 
Created attachment 295331 [details]
Problem as seen in the sharing panel (with scale=4)

I've been wondering for a while what's causing this. It seems to be caused by nothing ever removing headers from listboxrows. When the first row gets removed (or hidden), the second one takes its place and now has a header even though it shouldn't.
Comment 1 Timm Bäder 2015-01-24 15:29:50 UTC 
Created attachment 295332 [details] [review]
list-box-helper: Unset row header if unneeded

The usual implementation of the header func adds headers to all rows but
the first one. If the first row then gets removed, the second row
becomes the first and keeps its header, since nothing ever removes it.
Fix this by also removing the header if we are looking at the first row.
Comment 2 Bastien Nocera 2015-01-28 10:57:52 UTC 
Review of attachment 295332 [details] [review]:

Looks fine to me.
Comment 3 Timm Bäder 2015-01-28 11:23:49 UTC 
Attachment 295332 [details] pushed as fe77d80 - list-box-helper: Unset row header if unneeded