After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743401 - [window-list] Gjs-WARNING **: JS ERROR: TypeError: app is null
[window-list] Gjs-WARNING **: JS ERROR: TypeError: app is null
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.14.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-23 13:31 UTC by Christian Stadelmann
Modified: 2015-02-20 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-list: Fix for "app-less" windows (2.66 KB, patch)
2015-01-23 15:16 UTC, Florian Müllner 		committed Details | Review

Description Christian Stadelmann 2015-01-23 13:31:11 UTC 
When running window-list (most recent version as of today) under gnome-shell 3.14.3 I get this printed to stdout/syslog:

(gnome-shell:1899): Gjs-WARNING **: JS ERROR: TypeError: app is null
WindowTitle<._init@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:147
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
AppButton<._windowsChanged@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:485
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
AppButton<._init@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:436
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
WindowList<._addApp@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:996
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
WindowList<._onAppStateChanged@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:990
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
(gnome-shell:1899): Gjs-WARNING **: JS ERROR: TypeError: app is null
WindowTitle<._init@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:147
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
AppButton<._windowsChanged@/usr/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:485
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Comment 1 Florian Müllner 2015-01-23 15:16:19 UTC 
Created attachment 295281 [details] [review]
window-list: Fix for "app-less" windows

While rare, it is possible to have a window not associated with any app
(not even a fake window-based one). We currently throw an error when
trying to set the icon for such a window, so handle this case and
use a fallback icon instead of the app icon.

(I should add that I don't have a reproducer here, so this code is untested)
Comment 2 Rui Matos 2015-01-26 13:18:20 UTC 
Review of attachment 295281 [details] [review]:

looks good
Comment 3 Florian Müllner 2015-02-20 17:29:39 UTC 
Attachment 295281 [details] pushed as 93a1fd0 - window-list: Fix for "app-less" windows