GNOME Bugzilla – Bug 743332
aacparse adts header check issue
Last modified: 2015-04-07 10:36:46 UTC
I've met some aac clips play issue which played well on gst0.10. (I will attach one sample clip) And I checked the aacparse plugin and found that in gstaacparse.c gst_aac_parse_detect_stream() it add checkiing channel and frameisze validation: if (! channels || framesize) { GST_DEBUG_OBJECT (aacparse, "impossible ADTS configuration"); g_print("++ gstaacpase.c Line:%d, channels = %d, return false ++\n", __LINE__, channels); return FALSE; } The checking doesn't exist in gst0.10 aacparse. I just wondering if the channels need to be checked or is it a critical error which return the GST_ERROR and make the clip fail to play. Because the channel config area read from adts header may not exactly reflect the audio data channel number, and it is not a necessary input for AAC decoder (the actual audio channel number should be the output of the aac audio decoder by counting the single_channnel_element or pair_channel_element in the audio stream) Would you give us some advice about this? Thanks.
Created attachment 295144 [details] the sample aac clips with channel config is 0.
Thanks for taking the time to report this. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 721697 ***