After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743331 - Printers panel does not recognize 'inkCartridge' supply type
Printers panel does not recognize 'inkCartridge' supply type
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-22 04:48 UTC by Princeton Ferro
Modified: 2015-04-14 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for this (4.08 KB, patch)
2015-01-22 04:48 UTC, Princeton Ferro 		none Details | Review
Before patch. (105.19 KB, image/png)
2015-01-22 04:49 UTC, Princeton Ferro 		  Details
After patch (105.24 KB, image/png)
2015-01-22 04:49 UTC, Princeton Ferro 		  Details
Recognize more supply types (1.21 KB, patch)
2015-04-14 13:53 UTC, Marek Kašík 		committed Details | Review

Description Princeton Ferro 2015-01-22 04:48:43 UTC 
Created attachment 295141 [details] [review]
Patch for this

In the "Printers" panel, the supply label is displayed, but the supply levels are not rendered. This is because the function supply_levels_draw_cb does strcmp only with "ink" and "toner" labels. Anything else, such as "inkCartridge" (with Canon MG5400) is not recognized.

I have written a patch that fixes this, and also some rendering issues with the supply levels displayed in the drawing widget.
Comment 1 Princeton Ferro 2015-01-22 04:49:32 UTC 
Created attachment 295142 [details]
Before patch.
Comment 2 Princeton Ferro 2015-01-22 04:49:58 UTC 
Created attachment 295143 [details]
After patch
Comment 3 Bastien Nocera 2015-04-14 12:05:57 UTC 
Review of attachment 295141 [details] [review]:

Can you please split up the inkCartridge support from the rendering fixes?
Comment 4 Marek Kašík 2015-04-14 13:53:09 UTC 
Created attachment 301549 [details] [review]
Recognize more supply types

Hi,

I've split the part adding support for the 'inkCartridge' supply type + I've added 'tonerCartridge' supply type.

Regarding the rendering issue, I don't think that this is an issue. The showing of supply levels works as it was intended.
Marker levels are sorted and then a bar for the highest one is painted as first one and the others are painted over it.
The only flaw here is that if the levels are equal then you won't see one of them.
Comment 5 Bastien Nocera 2015-04-14 14:22:01 UTC 
Review of attachment 301549 [details] [review]:

Easy enough. Please commit and cherry-pick for gnome-3-14 as well.
Comment 6 Marek Kašík 2015-04-14 14:33:29 UTC 
Comment on attachment 301549 [details] [review]
Recognize more supply types

Thank you for the review. I've pushed the patch to master and gnome-3-14 branches.
Comment 7 Marek Kašík 2015-04-14 14:34:51 UTC 
Thank you Princeton for the patch. I'm closing this bug as fixed.