Created attachment 295635 [details] [review]
privacy: Rename "Show Notifications" label

To be clearer.

Created attachment 295636 [details] [review]
privacy: Dim explanatory label in history dialogue

Created attachment 295637 [details] [review]
privacy: Dim explanatory label in purge dialogue

Created attachment 295638 [details] [review]
privacy: Reword Purge dialogue

And add header labels

Thanks for implementing this Bastien. I've tried the patches; not all the changes seem positive to me, unfortunately.

I've updated the mockups [1], and can provide a list of the changes compared with the patches, if that would be helpful.

[1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/privacy/current-gen.png

(In reply to Allan Day from comment #5)
> Thanks for implementing this Bastien. I've tried the patches; not all the
> changes seem positive to me, unfortunately.
> 
> I've updated the mockups [1], and can provide a list of the changes compared
> with the patches, if that would be helpful.
> 
> [1]
> https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/
> system-settings/privacy/current-gen.png

That would be good, so I can at least mark the patches that we don't want as rejected.

Review of attachment 295635 [details] [review]:

Looks good to me

Review of attachment 295636 [details] [review]:

Doesn't apply on master, and from the discussion, might need an update.

Review of attachment 295637 [details] [review]:

Looks good, but doesn't apply on master.

Review of attachment 295638 [details] [review]:

From the discussion, needs an update (and doesn't apply on master)

Review of attachment 295637 [details] [review]:

Already fixed in bebaf47da1b501ba4a56e2544d7106e88ab6f155

Moved the one patch left-over to https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/417