Created attachment 294909 [details] [review]
wacom: Use the "display" setting from org.gnome.desktop.peripherals.tablet

Review of attachment 294909 [details] [review]:

This looks good but I can't test

Review of attachment 294909 [details] [review]:

Note that this patch is in the wrong place.

1) Do the patch against gnome-settings-daemon
2) Update it in gnome-control-center through "make update-from-gsd"

::: panels/wacom/gsd-wacom-device.c
@@ +1660,3 @@
 
+        if (p->settings != NULL) {
+                g_object_unref (p->settings);

g_clear_object();

Created attachment 295030 [details] [review]
wacom: Remove GsdWacomDevice dependency on GsdDeviceMapper

Just lookup the display from settings using internal functions, instead
of looking it up from the GsdDeviceMapper

Created attachment 295031 [details] [review]
wacom: Ensure the "display" setting is set on the right schema

This code was brought back after reverting f4b8633745c, make sure
it uses the right GSettings.

These two patches are for g-s-d, in order to make the necessary API available

Created attachment 295032 [details] [review]
Update device configuration from gnome-settings-daemon

GsdWacomDevice has been updated, dragging GsdDeviceManager as a dependency
from g-s-d, which has been added to panels/common, and compiled as a
separate static libary, which is used by the wacom and mouse modules.

gsd-input-helper.[ch] is now in such library and has been removed from
the panel directories.

This last patch is for g-c-c, a somewhat big update, as GsdDeviceManager is added. The first g-s-d patches are necessary so we don't drag the GsdDeviceMapper dependency as well, which is sort of meaningless to g-c-c

Review of attachment 295030 [details] [review]:

looks good

::: plugins/wacom/gsd-wacom-device.c
@@ +841,1 @@
+	if (rr_screen == NULL) {

style nit, no braces needed

Review of attachment 295031 [details] [review]:

right

Review of attachment 295031 [details] [review]:

actually, no, you need to unref the gsettings instance in those table variables

Review of attachment 295032 [details] [review]:

looks mostly fine, but I'll let Bastien take a look too :-)

::: panels/mouse/Makefile.am
@@ -21,3 @@
 	gnome-mouse-properties.h	\
-	gsd-input-helper.c		\
-	gsd-input-helper.h		\

Need to add -I$(top_srcdir)/panels/common to AM_CPPFLAGS and libdevice.la should be added to LIBADD here and in shell/Makefile.am:gnome_control_center_LDADD

Attachment 295030 [details] pushed as 96ff40d - wacom: Remove GsdWacomDevice dependency on GsdDeviceMapper
Attachment 295031 [details] pushed as 0002e5d - wacom: Ensure the "display" setting is set on the right schema

Attachment 295032 [details] pushed as be8d68c - Update device configuration from gnome-settings-daemon