After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743180 - padding is not updated correctly
padding is not updated correctly
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-19 13:37 UTC by Ondrej Holy
Modified: 2015-02-11 09:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update paddings on size allocate (4.45 KB, patch)
2015-01-19 13:37 UTC, Ondrej Holy 		none Details | Review
screenshot with broken padding (44.48 KB, image/png)
2015-01-19 13:38 UTC, Ondrej Holy 		  Details
update padding on style updated (4.27 KB, patch)
2015-01-27 15:42 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-01-19 13:37:15 UTC 
Created attachment 294883 [details] [review]
update paddings on size allocate

Padding is wrong for some widgets with gtk+ master. Padding is updated for some widgets once, when creating the widgets. However the padding should be updated on "size-allocate" signal to reflect widget changes.
Comment 1 Ondrej Holy 2015-01-19 13:38:17 UTC 
Created attachment 294884 [details]
screenshot with broken padding

See the account type, or last login fields...
Comment 2 Ondrej Holy 2015-01-19 13:39:09 UTC 
It affects other panels (at least printers) which are using this widgets...
Comment 3 Ondrej Holy 2015-01-27 15:42:24 UTC 
Created attachment 295548 [details] [review]
update padding on style updated

Patch is changed to use "style-updated" (after discussion on #control-center).
Comment 4 Bastien Nocera 2015-01-27 16:05:27 UTC 
Review of attachment 295548 [details] [review]:

That looks fine to me.
Comment 5 Ondrej Holy 2015-01-27 16:14:51 UTC 
Comment on attachment 295548 [details] [review]
update padding on style updated

commit a4521c15d5f1bf29adeb73d5e345804e67ea7454
Comment 6 Ondrej Holy 2015-01-27 16:15:05 UTC 
Thanks for the review!
Comment 7 Ondrej Holy 2015-02-10 11:48:06 UTC 
It seems it isn't fixed properly :-( The padding is wrong rarely. It seems style_updated signal isn't emitted properly. The widget get several style_updated signals usually. When the padding is wrong, only one signal was handled (and style context got zero values)...
Comment 8 Ondrej Holy 2015-02-11 09:34:21 UTC 
I've rebuilt gtk+ with all dependencies. It seems it is working reliably now (succeeded in tens of iteration of my test). There are correct values for all style_updated signals, also for the first one, so closing again...