GNOME Bugzilla – Bug 743148
patch to enable HEAD install in Homebrew
Last modified: 2021-07-05 11:01:21 UTC
Created attachment 294820 [details] patch using glibtoolize if libtoolize not found Homebrew installs libtoolize as glibtoolize to not interfere with the one shipped with MacOS. However, libtoolize is needed to install libxslt from git master and provide a HEAD option to `brew install`. The attached patch to autogen.sh uses glibtoolize if libtoolize is not found. There might be a more elegant way of solving this, but this "quick fix" suffices to get the cutting edge libxslt compiled via Homebrew. The same patch has been included in the according Homebrew pull request at https://github.com/Homebrew/homebrew/pull/35986 but the maintainers would prefer for it to be merged upstream instead.
Looking at other packages, some use a $LIBTOOLIZE env-var (if set) to override a PATH search (that way anyone can choose anything...users on systems that have other filenames, or to use an explicit full path to get something that is not first-in-PATH). But more significantly, autogen.sh appears to run each of libtoolize, alocal, automake, autoconf explicitly after testing for each explicitly. Why not *just* use autoreconf, which does all of them automatically? It also supports the LIBTOOLIZE env var, as well as similar vars for all of the other autotool components.
(In reply to comment #1) > But more significantly, autogen.sh appears to run each of libtoolize, alocal, > automake, autoconf explicitly after testing for each explicitly. Why not *just* > use autoreconf, which does all of them automatically? Indeed, but I tired to interfere with the maintainer's code as little as possible. Anyways, in the newly attached patch I replaced the single calls of libtoolize, aclocal, automake, and autoconf with one call of autoreconf. After testing, it still seems to compile fine.
Created attachment 294841 [details] [review] using autoreconf instead of single calls
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/libxslt/-/issues/ Thank you for your understanding and your help.