Created attachment 294716 [details] [review]
embed-prefs: properly update spell check langs when changed

When the list of languages is changed, don't forget to update the list
of languages for which spell checking is enabled. Otherwise, spell
checking for the newly-selected language(s) won't work until the browser
is restarted.

Review of attachment 294716 [details] [review]:

Cool!

::: embed/ephy-embed-prefs.c
@@ +367,3 @@
+
+  if (g_settings_get_boolean (EPHY_SETTINGS_WEB, EPHY_PREFS_WEB_ENABLE_SPELL_CHECKING))
+  {

Please, move this { to the previous line.

@@ +370,3 @@
+    char **normalized = normalize_languages ((char **)array->data);
+    webkit_web_context_set_spell_checking_languages (web_context, (const char * const *)normalized);
+    g_strfreev (normalized);

We could probably add a helper function set_spell_checking_languages, that receives the not normalized languages.

Created attachment 296033 [details] [review]
embed-prefs: properly update spell check langs when changed

When the list of languages is changed, don't forget to update the list
of languages for which spell checking is enabled. Otherwise, spell
checking for the newly-selected language(s) won't work until the browser
is restarted.

Comment on attachment 296033 [details] [review]
embed-prefs: properly update spell check langs when changed

Actually having read your comment in bug #743069 regarding putting the normalize helper in ephy-langs, I will commit the original patch with just the brace fixed.

Attachment 294716 [details] pushed as 970d984 - embed-prefs: properly update spell check langs when changed