After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743041 - gstglapi.h not compiling with MSVC (Visual Studio 2013)
gstglapi.h not compiling with MSVC (Visual Studio 2013)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.4.5
Other Windows
: Normal normal
: 1.4.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 743043 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-16 14:24 UTC by lasse
Modified: 2015-01-16 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch - Hopefully functional :S (230 bytes, patch)
2015-01-16 18:13 UTC, lasse 		none Details | Review
Proposed patch v2 - Now Unified! (230 bytes, patch)
2015-01-16 18:28 UTC, lasse 		none Details | Review

Description lasse 2015-01-16 14:24:00 UTC 
On line 82 in the gstglapi.h file:

#  if __WIN32__ || _WIN32

causes an

Error	1	error C1017: invalid integer constant expression	d:\sdks\gstreamer\1.0\x86\include\gstreamer-1.0\gst\gl\gstglapi.h	82

error.

__tim suggested fixing this problem thusly, which seems to work:

#  if defined(__WIN32__) || defined(_WIN32)

So... Yeah, maybe do that? Hopefully this doesn't cause other headaches.
Comment 1 Sebastian Dröge (slomo) 2015-01-16 15:04:45 UTC 
*** Bug 743043 has been marked as a duplicate of this bug. ***
Comment 2 Sebastian Dröge (slomo) 2015-01-16 15:05:39 UTC 
Can you attach patches here for this change, and the one you mention in the other bug?

You can create them by locally committing with GIT, and then using "git format-patch -1" (or how many commits you want to export as patches).
Comment 3 lasse 2015-01-16 18:13:29 UTC 
Created attachment 294706 [details] [review]
Proposed patch - Hopefully functional :S
Comment 4 lasse 2015-01-16 18:28:36 UTC 
Created attachment 294707 [details] [review]
Proposed patch v2 - Now Unified!
Comment 5 Matthew Waters (ystreet00) 2015-01-16 23:59:39 UTC 
commit 174ea7af7b5bdd512574a16d9725030e5e783136
Author: Lasse Laursen <lasse@lasselaursen.com>
Date:   Sat Jan 17 10:06:40 2015 +1100

    glapi: fix compilation with latest MSVC
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743041

and 1.4 c3ca2f04fe5131362f46ae3fdd12ebe5b3b55773