Created attachment 294515 [details] [review]
Remove deprecated methods

Created attachment 294517 [details] [review]
Remove deprecated methods

Review of attachment 294517 [details] [review]:

Thanks for the patch! I am sorry that it went unreviewed for so long.

::: libgd/gd-main-icon-view.c
@@ +300,3 @@
+	  gtk_render_frame (context,
+			    cr, 0, 0, allocation.width
+			    allocation.height);

Does this actually work with rubberband selection?

The code in this function is trying to draw the border around a rubberband selection, which is not necessarily a rectangle. Think of multiple rectangles of different sizes stuck to each other on different edges. It's a polygon with right-angled corners, but not necessarily a rectangle.

Therefore, it doesn't look like we can replace it with gtk_render_frame.

Created attachment 373861 [details] [review]
main-icon-view: Ignore deprecation warnings

I think that we might have to resort to locally disabling the deprecation instead.

Review of attachment 294517 [details] [review]:

I tested this with gnome-documents. Instead of drawing a solid border around a translucent polygon, it draws a completely solid polygon that hides the thumbnails of the selected items.

::: libgd/gd-main-icon-view.c
@@ +299,3 @@
 	  state = gtk_widget_get_state_flags (widget);
+	  gtk_render_frame (context,
+			    cr, 0, 0, allocation.width

Nitpick: missing comma.

Comment on attachment 373861 [details] [review]
main-icon-view: Ignore deprecation warnings

I have pushed this to master to reduce backlog on bugzilla. If there's a better way to do this, or any other feedback, it would be better to continue on GitLab instead.