After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742898 - g_value_type_transformable() description differs from the code
g_value_type_transformable() description differs from the code
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
2.43.x
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-01-14 09:52 UTC by Kjell Ahlstedt
Modified: 2016-04-28 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch: gvalue: Fix description of g_value_type_transformable() (1.09 KB, patch)
2015-01-14 09:58 UTC, Kjell Ahlstedt 		committed Details | Review

Description Kjell Ahlstedt 2015-01-14 09:52:09 UTC 
Bug 707111 added the following sentence to the description of
g_value_type_transformable():

  Note that for the types to be transformable, they must be compatible and a
  transform function must be registered.

But the code is 

  return (g_value_type_compatible (src_type, dest_type) ||
    transform_func_lookup (src_type, dest_type) != NULL);

Note ||, not &&.
Comment 1 Kjell Ahlstedt 2015-01-14 09:58:11 UTC 
Created attachment 294499 [details] [review]
patch: gvalue: Fix description of g_value_type_transformable()

Patch, assuming that the code is correct and the description is wrong.
Comment 2 Kjell Ahlstedt 2015-04-16 08:34:34 UTC 
Why no comment? I suppose that it will take only a few minutes to accept or
reject the patch in comment 1.

I'd also be happy to delete "Note that" from the description. It seems
unnecessary there.
Comment 3 Kjell Ahlstedt 2016-03-17 10:56:37 UTC 
Closing this trivial bug report. Obviously no glib developer is interested.
Comment 4 Emmanuele Bassi (:ebassi) 2016-03-17 11:13:31 UTC 
Please, do not close bugs just because they have no comment.
Comment 5 Emmanuele Bassi (:ebassi) 2016-03-17 11:14:37 UTC 
Review of attachment 294499 [details] [review]:

LGTM.
Comment 6 Kjell Ahlstedt 2016-04-13 10:59:30 UTC 
I haven't found a good description of what accepted-commit_after_freeze means.
Does it mean in this case that that my patch must not be included in glib
2.48.x, and I shall wait with pushing it to the master branch until the
glib-2-48 branch has been created?