After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742829 - Update to new libinput API for pointer_axis events
Update to new libinput API for pointer_axis events
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
: 742975 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-13 03:33 UTC by Peter Hutterer
Modified: 2015-01-16 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-evdev-use-libinput-s-new-merged-scroll-events.patch (2.10 KB, patch)
2015-01-13 03:33 UTC, Peter Hutterer 		reviewed Details | Review
Enchanced Whot's patch to use the discrete axis value for wheel events (3.52 KB, patch)
2015-01-16 00:05 UTC, Armin K. 		none Details | Review
Enchanced Whot's patch to use the discrete axis value for wheel events (3.52 KB, patch)
2015-01-16 00:08 UTC, Armin K. 		none Details | Review
Enchanced Whot's patch to use the discrete axis value for wheel events (3.52 KB, patch)
2015-01-16 00:10 UTC, Armin K. 		reviewed Details | Review
Enchanced Whot's patch to use the discrete axis value for wheel events (3.53 KB, patch)
2015-01-16 00:20 UTC, Armin K. 		committed Details | Review

Description Peter Hutterer 2015-01-13 03:33:46 UTC 
Created attachment 294381 [details] [review]
0001-evdev-use-libinput-s-new-merged-scroll-events.patch

The scrolling event API changes in libinput 0.8 to include all axes changes in the same event.

Patch filed for review, the changes aren't on libinput master yet (trying to get all patches public first)
Comment 1 Rui Matos 2015-01-15 14:06:25 UTC 
Review of attachment 294381 [details] [review]:

Clutter indentation is 2 spaces but otherwise this looks good.

libinput 0.8 is now out too so we should land this soon
Comment 2 Carlos Garnacho 2015-01-15 15:24:32 UTC 
*** Bug 742975 has been marked as a duplicate of this bug. ***
Comment 3 Emmanuele Bassi (:ebassi) 2015-01-15 15:43:14 UTC 
we'll need to bump up libinput in both jhbuild and gnome-continuous.
Comment 4 Emmanuele Bassi (:ebassi) 2015-01-15 15:43:55 UTC 
also, this needs a bump to the libinput version check in configure.ac.
Comment 5 Armin K. 2015-01-16 00:05:06 UTC 
Created attachment 294623 [details] [review]
Enchanced Whot's patch to use the discrete axis value for wheel events

It's basically a mirror of weston patch that does the same.

http://cgit.freedesktop.org/wayland/weston/commit/?id=5dddd411d6d8587267529d0478c5dc68e9521047
Comment 6 Armin K. 2015-01-16 00:08:31 UTC 
Created attachment 294625 [details] [review]
Enchanced Whot's patch to use the discrete axis value for wheel events 

Fixed minor coding style issue.
Comment 7 Armin K. 2015-01-16 00:10:48 UTC 
Created attachment 294626 [details] [review]
Enchanced Whot's patch to use the discrete axis value for wheel events 

Really fixed minor coding style issue.
Comment 8 Emmanuele Bassi (:ebassi) 2015-01-16 00:16:19 UTC 
Review of attachment 294626 [details] [review]:

thanks for the patch!

looks generally good, two minor style issues.

::: clutter/evdev/clutter-device-manager-evdev.c
@@ +1214,3 @@
+
+        axis = LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL;
+        if (libinput_event_pointer_has_axis (axis_event, axis)) {

coding style: the curly brace needs to go on another line and indentation level, e.g.:

   if (condition)
     {
       statement_1;
       ...
     }

@@ +1223,2 @@
+        axis = LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL;
+        if (libinput_event_pointer_has_axis (axis_event, axis)) {

coding style, same as above.
Comment 9 Armin K. 2015-01-16 00:20:50 UTC 
Created attachment 294628 [details] [review]
Enchanced Whot's patch to use the discrete axis value for wheel events

Another coding style fix as pointed out by ebassi.
Comment 10 Emmanuele Bassi (:ebassi) 2015-01-16 00:26:21 UTC 
Review of attachment 294628 [details] [review]:

looks good.
Comment 11 Emmanuele Bassi (:ebassi) 2015-01-16 14:52:01 UTC 
Pushed attachment 294628 [details] [review] to master