After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742653 - gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate
gtkfilechooserwidget: When using an extra widget, show or hide the filter com...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2015-01-09 15:37 UTC by Iain Lane
Modified: 2015-01-11 01:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate (1.40 KB, patch)
2015-01-09 15:37 UTC, Iain Lane 		committed Details | Review
reproducer (454 bytes, text/x-python)
2015-01-09 15:37 UTC, Iain Lane 		  Details

Description Iain Lane 2015-01-09 15:37:20 UTC 
A bug that appeared between 3.12 and 3.14 is that when one sets an extra widget
on a GtkFileChooser, the filter combo is always shown even if there are no
filters.
Comment 1 Iain Lane 2015-01-09 15:37:23 UTC 
Created attachment 294167 [details] [review]
gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate
Comment 2 Iain Lane 2015-01-09 15:37:49 UTC 
Created attachment 294168 [details]
reproducer
Comment 3 Matthias Clasen 2015-01-09 16:19:30 UTC 
Review of attachment 294167 [details] [review]:

that looks easy enough, thanks. Would be good to cherry-pick to the 3.14 branch as well
Comment 4 Iain Lane 2015-01-09 16:24:17 UTC 
thanks, please push for me
Comment 5 Matthias Clasen 2015-01-11 01:43:51 UTC 
Attachment 294167 [details] pushed as 8c5094c - gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate