After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742553 - Add LGI for libpeas, required for Lua plugin support
Add LGI for libpeas, required for Lua plugin support
Status: RESOLVED OBSOLETE
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-01-07 21:02 UTC by Garrett Regier
Modified: 2021-05-17 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
3.16: Remove old libpeas deps (1.03 KB, patch)
2015-01-27 17:31 UTC, Garrett Regier
committed Details | Review

Comment 1 Javier Jardón (IRC: jjardon) 2015-01-27 14:23:45 UTC
We already track libpeas master branch in jhbuild modulesets:
https://git.gnome.org/browse/jhbuild/tree/modulesets/gnome-suites-core-deps-3.16.modules#n1099
Comment 2 Garrett Regier 2015-01-27 14:30:01 UTC
This is about fixing all of the deps and possibly adding LGI as the summary says.

Reopening.
Comment 3 Garrett Regier 2015-01-27 17:31:42 UTC
Created attachment 295558 [details] [review]
3.16: Remove old libpeas deps
Comment 4 Garrett Regier 2015-01-27 17:35:53 UTC
I'm not familiar enough with JHBuild's internals to add LGI.

My methodology to build it on Travis CI:
    make PREFIX="${PREFIX}" CFLAGS="${CFLAGS} -I/usr/include/lua5.1"
    make install PREFIX="${PREFIX}"


Then JHBuild needs to be taught to fixup LUA_PATH and LUA_CPATH:
    LUA_PATH="`lua5.1 -e 'print(package.path)'`"
    LUA_PATH="${PREFIX}/share/lua/5.1/?/init.lua;${LUA_PATH}"
    LUA_PATH="${PREFIX}/share/lua/5.1/?.lua;${LUA_PATH}"

    LUA_CPATH="`lua5.1 -e 'print(package.cpath)'`"
    LUA_CPATH="${PREFIX}/lib/lua/5.1/?.so;${LUA_CPATH}"


Libpeas requires Lua 5.1 or LuaJIT (which is Lua 5.1 compliant).
Comment 5 Javier Jardón (IRC: jjardon) 2015-01-28 06:23:11 UTC
Comment on attachment 295558 [details] [review]
3.16: Remove old libpeas deps

sure
Comment 6 Javier Jardón (IRC: jjardon) 2015-01-28 06:23:47 UTC
Any reason to enable the lua bindings? Does any GNOME modules depends on them?
Comment 7 Garrett Regier 2015-01-28 09:02:26 UTC
(In reply to comment #6)
> Any reason to enable the lua bindings? Does any GNOME modules depends on them?

Nope, but then again according to the modulesets, it looks like the same can be said for Seed and java-gnome.
Comment 8 Frederic Peters 2015-01-28 09:10:44 UTC
I was about to remove Seed from libpeas dependency (and move seed itself to the gnome-world moduleset); I have now done so.
Comment 9 Garrett Regier 2015-05-14 11:10:35 UTC
Comment on attachment 295558 [details] [review]
3.16: Remove old libpeas deps

Also removed it from 3.18
Comment 10 GNOME Infrastructure Team 2021-05-17 16:01:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/jhbuild/-/issues/212.