GNOME Bugzilla – Bug 742520
Scroll the view, not the list
Last modified: 2015-01-20 14:18:35 UTC
The list of apps has a scroll bar attached. Since the list isn't very tall, this can be a bit uncomfortable, and isn't very inviting. Scrolling the view instead would give more room for viewing the list, and would provide a larger scroll area, making the list easier to use. It would probably be a good idea to increase the height of the panel at the same time. See: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/notifications/notifications-wireframes.png
Created attachment 294673 [details] [review] Scroll the view not just the list This patch implements the proposed change.
Created attachment 294674 [details] screenshot of the result
Review of attachment 294673 [details] [review]: ::: panels/notifications/cc-notifications-panel.c @@ +137,1 @@ gtk_container_add (GTK_CONTAINER (panel), w); We need to gtk_container_set_focus_vadjustment() here so that keynav makes the panel scroll properly. ::: panels/notifications/notifications.ui @@ +7,3 @@ + <property name="can_focus">True</property> + <property name="hscrollbar_policy">never</property> + <property name="shadow_type">in</property> I'm not a designer but this shadow shouldn't be here since it adds a frame around the whole panel which is just visual noise @@ +80,2 @@ <child> + <object class="GtkListBox" id="ccnotify-app-listbox"> The list box, OTOH, should have a GtkFrame around it like other panels do, e.g. the sharing panel.
Created attachment 294972 [details] [review] Scroll the view not just the list (In reply to comment #3) > Review of attachment 294673 [details] [review]: > > ::: panels/notifications/cc-notifications-panel.c > @@ +137,1 @@ > gtk_container_add (GTK_CONTAINER (panel), w); > > We need to gtk_container_set_focus_vadjustment() here so that keynav makes the > panel scroll properly. Done + added handling of "keynav-failed" signal. > ::: panels/notifications/notifications.ui > @@ +7,3 @@ > + <property name="can_focus">True</property> > + <property name="hscrollbar_policy">never</property> > + <property name="shadow_type">in</property> > > I'm not a designer but this shadow shouldn't be here since it adds a frame > around the whole panel which is just visual noise Set to none. > @@ +80,2 @@ > <child> > + <object class="GtkListBox" id="ccnotify-app-listbox"> > > The list box, OTOH, should have a GtkFrame around it like other panels do, e.g. > the sharing panel. Added.
Review of attachment 294972 [details] [review]: works great, it's just missing freeing the sections lists on dispose(), with that fixed
Comment on attachment 294972 [details] [review] Scroll the view not just the list (In reply to comment #5) > Review of attachment 294972 [details] [review]: > > works great, it's just missing freeing the sections lists on dispose(), with > that fixed Thank you for the review. I've add the freeing there and pushed it to master.