After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742386 - gdbusconnection: Don't g_printerr() when exiting
gdbusconnection: Don't g_printerr() when exiting
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-01-05 15:23 UTC by Colin Walters
Modified: 2015-08-06 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdbusconnection: Don't g_printerr() when exiting (1.76 KB, patch)
2015-01-05 15:23 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2015-01-05 15:23:17 UTC 
exit-on-close for a DBus connection is a completely normal thing.  On
a regular GNOME login, gdm retains the X server, but terminates the
session login bus and associated helpers like gnome-settings-dameon,
the a11y tools, etc.

I've seen several downstream reports of confusion as to what these
apparent error messages mean in the system log.  It doesn't help
that they're so obtuse.

We're also printing them to stderr, when this is not an error.

The reason this was introduced is presumably some people were confused
as to why their process exited when the system bus did.  But the
solution for that I believe is documentation, not printing stuff to
everyone's system log in normal operation.
Comment 1 Colin Walters 2015-01-05 15:23:20 UTC 
Created attachment 293826 [details] [review]
gdbusconnection: Don't g_printerr() when exiting
Comment 2 Allison Karlitskaya (desrt) 2015-01-05 15:45:18 UTC 
My understanding of the future is that exit-on-close will stop being a thing, replaced by kill-by-cgroup-membership...
Comment 3 Colin Walters 2015-01-05 16:48:50 UTC 
I'm not sure about that.  Old thread: https://lists.fedoraproject.org/pipermail/desktop/2008-January/003810.html
Comment 4 Colin Walters 2015-01-05 17:52:31 UTC 
Even were we to switch to cgroups in some future GNOME version, I'd like to fix this bug in the existing version, since I try to pull in newer glib versions.

In parallel, we could investigate using prctl(PR_SET_PDEATHSIG, SIGTERM) more.  This would help for gnome-settings-daemon, if gnome-session exited first (before the session bus).  The a11y bus uses it already.  This is more efficient too, as we don't get scheduled only to print something and exit.
Comment 5 Colin Walters 2015-08-06 12:52:02 UTC 
Comment on attachment 293826 [details] [review]
gdbusconnection: Don't g_printerr() when exiting

No real objections, so applying.