GNOME Bugzilla – Bug 742116
Huge openshot icon on notification list
Last modified: 2015-01-07 18:11:17 UTC
Created attachment 293478 [details] huge icon Huge openshot icon on notification list please check screenshot attached. thanks regards althaser
Hi Pedro, I can not reproduce the problem. Are all icons as big as the one I see on the screenshot? Which version of gnome-control-center do you use? Which distribution do you use? Marek
Hey Marek, It is just openshot that has a big icon, everything else is fine. I am using Debian sid here, with gnome-control-center 1:3.14.2-2 thanks althaser
Looks like an application bug, but we should probably do better than this. The attached patch below should be able to fix this, but I would have expected gtk_image_new_from_gicon() to do the resizing job itself... Which version of openshot are you using? A link to the exact package you're using on https://www.debian.org/distrib/packages would be appreciated.
Created attachment 293822 [details] [review] notifications: Force smaller icons To work-around application icons that would be too big.
Hey Bastien, I am using openshot 1.4.3-1.1 -> https://packages.debian.org/sid/openshot Cheers, Pedro
(In reply to comment #3) > Looks like an application bug, but we should probably do better than this. The > attached patch below should be able to fix this, but I would have expected > gtk_image_new_from_gicon() to do the resizing job itself... The problem here is that gdk_pixbuf_new_from_stream_at_scale() in icon_info_ensure_scale_and_pixbuf() from gtkicontheme.c gets negative size (-48 in this case). If I switch the sign then the icon has correct size. I'll continue on this tomorrow.
(In reply to comment #6) > (In reply to comment #3) > > Looks like an application bug, but we should probably do better than this. The > > attached patch below should be able to fix this, but I would have expected > > gtk_image_new_from_gicon() to do the resizing job itself... > > The problem here is that gdk_pixbuf_new_from_stream_at_scale() in > icon_info_ensure_scale_and_pixbuf() from gtkicontheme.c gets negative size (-48 > in this case). If I switch the sign then the icon has correct size. > I'll continue on this tomorrow. That sounds like a "-1" to mean "don't resize it" got misinterpreted somewhere along the way.
Yes, it seems so. The code which uses the unhandled -1 (in icon_info->scale) got in by this commit: https://git.gnome.org/browse/gtk+/commit/?id=fea939b3d75a97ded2e631235644500fcc2301cf . I'll file a gtk+ bug for this.
Good detective work, thanks Marek.
(In reply to comment #9) > Good detective work, thanks Marek. You're welcome. I've filed the bug here: https://bugzilla.gnome.org/show_bug.cgi?id=742455.
Review of attachment 293822 [details] [review]: Thank you for the patch. It looks good and fixes the problem for me.
Attachment 293822 [details] pushed as db756d7 - notifications: Force smaller icons