After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741635 - fingerprint dialog crashes when closing
fingerprint dialog crashes when closing
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-17 10:31 UTC by Ondrej Holy
Modified: 2014-12-17 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: don't crash when closing fingerprint dialog (1.15 KB, patch)
2014-12-17 10:31 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2014-12-17 10:31:40 UTC 
Created attachment 292880 [details] [review]
user-accounts: don't crash when closing fingerprint dialog

Enroll data are used after destroying when closing dialog. It causes crash while setting label. Therefor we have to store the pointer for fingerprint button and use it to set the label after destroying the data.

We should get this fix in master and gnome-3-14 

It was filed downstream originally:
https://bugzilla.redhat.com/show_bug.cgi?id=1172352
Comment 1 Ondrej Holy 2014-12-17 10:35:25 UTC 
The bug is caused by the commit c218a21 (conversion to UmEditableButton).
Comment 2 Rui Matos 2014-12-17 11:19:37 UTC 
Review of attachment 292880 [details] [review]:

right, please push to both
Comment 3 Ondrej Holy 2014-12-17 11:37:26 UTC 
Comment on attachment 292880 [details] [review]
user-accounts: don't crash when closing fingerprint dialog

Thanks for the review.

Pushed to master and gnome-3-14 as:
commit af93bb814eefb3a6b28e8c6125c0fe29d7391744
commit e1d4cce44bdf3984816a11fa888141575df41d58