After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741342 - [PATCH] core: clean up half-done IP operations when re-entering NEED_AUTH state
[PATCH] core: clean up half-done IP operations when re-entering NEED_AUTH state
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1.0
 
 
Reported: 2014-12-10 16:28 UTC by Dan Williams
Modified: 2015-01-12 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-core-clean-up-half-done-IP-operations-when-re-enteri.patch (2.61 KB, text/x-c++)
2014-12-10 16:28 UTC, Dan Williams
  Details
0001-core-clean-up-half-done-IP-operations-when-re-enteri.patch (2.67 KB, patch)
2014-12-10 16:28 UTC, Dan Williams
none Details | Review

Description Dan Williams 2014-12-10 16:28:01 UTC
Created attachment 292453 [details]
0001-core-clean-up-half-done-IP-operations-when-re-enteri.patch

When the device decides it needs re-auth during IP config and returns
to the NEED_AUTH state, make sure we clean up any half-done IP operations
since they will be re-started after auth is completed and the
IP_CONFIG state is re-entered.
Comment 1 Dan Williams 2014-12-10 16:28:48 UTC
Created attachment 292454 [details] [review]
0001-core-clean-up-half-done-IP-operations-when-re-enteri.patch
Comment 2 Lubomir Rintel 2014-12-11 10:21:45 UTC
Looks good and I've verified it works fine for me.
Comment 3 Thomas Haller 2014-12-11 12:46:32 UTC
LGTM
Comment 4 Dan Williams 2014-12-11 15:25:57 UTC
Pushed as a1f4794c86d777f11e6201fdd110bf93c8299110