After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741285 - dashdemux: gst_dash_demux_setup_streams fails to initialise the segment numbers for live streams
dashdemux: gst_dash_demux_setup_streams fails to initialise the segment numbe...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-09 10:56 UTC by David Waring
Modified: 2014-12-10 01:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set next segment number on next_streams instead of streams (918 bytes, patch)
2014-12-09 10:56 UTC, David Waring
committed Details | Review

Description David Waring 2014-12-09 10:56:32 UTC
Created attachment 292350 [details] [review]
Set next segment number on next_streams instead of streams

gst_dash_demux_setup_streams has logic to find the correct segment/fragment numbers for each stream based on the current time. However this logic does not operate on the list of newly created streams and instead operates on an empty list. This is because gst_dash_demux_setup_all_streams creates the new streams in a next_streams list and the loop in gst_dash_demux_setup_streams operates on the current streams list. Either the next_streams need propagating to the current streams list before this loop, or the loop needs to operate on next_streams instead.

Included is a patch to change the loop to operate on next_streams instead.
Comment 1 Thiago Sousa Santos 2014-12-10 01:55:35 UTC
Thanks for the fix.
For future reference, please use the commit message style for the project. Just browse through git log and you will understand it.

commit b03acbf584cab286b8c869f4aa3bdc8e98059f65
Author: David Waring <david.waring@rd.bbc.co.uk>
Date:   Fri Dec 5 16:20:08 2014 +0000

    dashdemux: Find current segment in the streams that have just been setup
    
    Using demux->streams will just skip the whole loop as demux->streams will
    always be NULL at that point
    
    https://bugzilla.gnome.org/show_bug.cgi?id=741285