After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741129 - Correct couple translatable strings
Correct couple translatable strings
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.14.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-12-04 20:33 UTC by zilla
Modified: 2015-01-06 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.23 KB, patch)
2014-12-04 20:33 UTC, zilla
reviewed Details | Review
patch2 (3.51 KB, patch)
2014-12-06 19:56 UTC, zilla
reviewed Details | Review

Description zilla 2014-12-04 20:33:13 UTC
Created attachment 292149 [details] [review]
patch

I have spotted a couple of typos while translating
Comment 1 zilla 2014-12-06 19:56:09 UTC
Created attachment 292243 [details] [review]
patch2
Comment 2 Milan Crha 2015-01-05 14:52:18 UTC
Review of attachment 292149 [details] [review]:

Thanks for the bug report and patches. I agree with the second and I'm fine with the fourth change, but I do not know why you want to change the first and the third sentences. Especially the third looks fine to me. I'm not a native English speaker, of course.
Comment 3 Milan Crha 2015-01-05 14:54:37 UTC
Review of attachment 292243 [details] [review]:

I see, "sub-thread" is replaced with "subthread". My spellchecker doesn't like the second variant, it thinks it's not a properly spelled word, which is the reason why the former variant is used.
Comment 4 zilla 2015-01-05 15:09:34 UTC
I decided to change it to the spelling that has been used in the rest of the strings for subthread. It should be changed to either version though. 

As for the other changes it felt awkward to me. But I'm not a native speaker either.
Comment 5 zilla 2015-01-05 20:05:15 UTC
First sentence should be present perfect insted of past perfect. 

Third sentence I'm not 100% sure. Probably depends on context.
Comment 6 Milan Crha 2015-01-06 10:21:28 UTC
Okay, I merged the two patches into one commit with some minor changes on the questionable sentences and committed it into the sources:

Created commit c569546 in evo master (3.13.10+) [1]

[1] https://git.gnome.org/browse/evolution/commit/?id=c569546