After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740886 - Port to GNotification API
Port to GNotification API
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-29 13:30 UTC by Florian Müllner
Modified: 2014-11-29 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Port to GNotification (9.26 KB, patch)
2014-11-29 13:30 UTC, Florian Müllner 		committed Details | Review
Remove libnotify dependency (3.02 KB, patch)
2014-11-29 13:30 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-11-29 13:30:16 UTC 
See patches.
Comment 1 Florian Müllner 2014-11-29 13:30:20 UTC 
Created attachment 291773 [details] [review]
app: Port to GNotification
Comment 2 Florian Müllner 2014-11-29 13:30:25 UTC 
Created attachment 291774 [details] [review]
Remove libnotify dependency

After the port to GNotifications, libnotify is only used to check
whether the server supports persistence. Just call the underlying
DBus method directly and remove the dependency.
Comment 3 Cosimo Cecchi 2014-11-29 19:12:19 UTC 
Thanks, Florian! I have wanted to do this for a while.
The unmount notification code is actually not used in Nautilus anymore and was waiting to be ported before being moved to GtkPlacesSidebar; I have done that in bug 740896.
Pushed your patches plus some cleanups.

Attachment 291773 [details] pushed as 3c7ef4a - app: Port to GNotification
Attachment 291774 [details] pushed as a98c930 - Remove libnotify dependency