After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740868 - Remove CLRBUF_24BPP
Remove CLRBUF_24BPP
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: RDP
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-28 16:58 UTC by Jean-Philippe Menil
Modified: 2014-11-28 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (remove CLRBUF_24BPP) (984 bytes, patch)
2014-11-28 16:58 UTC, Jean-Philippe Menil 		none Details | Review
improved patch (1.32 KB, patch)
2014-11-28 17:10 UTC, David King 		committed Details | Review

Description Jean-Philippe Menil 2014-11-28 16:58:06 UTC 
Created attachment 291733 [details] [review]
Patch (remove CLRBUF_24BPP)

Support for 24bpp was removed from freerdp repository in commit 02c1bf14ce1f3ad2199a349066548977916d9c06

Patch is attached
Comment 1 David King 2014-11-28 17:10:49 UTC 
Created attachment 291734 [details] [review]
improved patch

I do not have an older version of FreeRDP installed, but don't you also need to include the final argument in the ifdef (see attached)?
Comment 2 Jean-Philippe Menil 2014-11-28 18:00:42 UTC 
Yes, you're right, i've missed it.

Thanks!
Comment 3 David King 2014-11-28 18:02:37 UTC 
Review of attachment 291734 [details] [review]:

Thanks! Pushed to master as 2fd545b77c3a2c5f0bc1b0fc5f851857127cc2f3.