After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740675 - playsink: continues playback, reset mute property
playsink: continues playback, reset mute property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-25 08:48 UTC by Andrei Sarakeev
Modified: 2014-12-12 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.52 KB, patch)
2014-11-25 08:48 UTC, Andrei Sarakeev 		committed Details | Review

Description Andrei Sarakeev 2014-11-25 08:48:30 UTC 
Created attachment 291438 [details] [review]
fix

1. set mute=true
2. play media1 (Ok)
3. play media without audio (audiochain removed)
4. play media2 (audiochain created, mute=*false*)
Comment 1 Andrei Sarakeev 2014-11-25 08:50:52 UTC 
gstdiscoverer.h contains typo:
(Gbject*)info
Comment 2 Sebastian Dröge (slomo) 2014-11-25 09:25:08 UTC 
commit e5c6f59140f2b52e9ce3e5b0faa5ee4cd0efdc51
Author: Andrei Sarakeev <sarakusha@gmail.com>
Date:   Tue Nov 25 11:38:34 2014 +0300

    playsink: Reset mute property of the sink to playsink's value when setting up the audio chain
    
    Otherwise the following can happen:
    1. set mute=true
    2. play media1 (Ok)
    3. play media without audio (audiochain removed)
    4. play media2 (audiochain created, mute=*false*)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740675
Comment 3 Sebastian Dröge (slomo) 2014-11-25 09:25:41 UTC 
commit 274d8066ce6123930fdb823413470ad0e2017118
Author: Andrei Sarakeev <sarakusha@gmail.com>
Date:   Tue Nov 25 11:38:34 2014 +0300

    discoverer: fix typo in header file
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740675
Comment 4 Tim-Philipp Müller 2014-12-12 16:03:24 UTC 
Cherry-picked into 1.4 branch.