After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740242 - Port HTML5 Viewer to WebKit2
Port HTML5 Viewer to WebKit2
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: viewers
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks: 686373
 
 
Reported: 2014-11-17 09:37 UTC by Marcos Chavarria Teijeiro
Modified: 2014-11-20 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes the problem. (2.13 KB, patch)
2014-11-17 09:40 UTC, Marcos Chavarria Teijeiro 		needs-work Details | Review
Remove Lang declaration (2.06 KB, patch)
2014-11-18 08:26 UTC, Marcos Chavarria Teijeiro 		none Details | Review
Patch (2.48 KB, patch)
2014-11-18 10:19 UTC, Marcos Chavarria Teijeiro 		committed Details | Review

Description Marcos Chavarria Teijeiro 2014-11-17 09:37:03 UTC 
WebKit 1 has been officially deprecated. We should implement the viewer in the WebKit2.

This should be easy... I'm going to attach a patch that should implement it.
Comment 1 Marcos Chavarria Teijeiro 2014-11-17 09:40:37 UTC 
Created attachment 290844 [details] [review]
Patch that fixes the problem.
Comment 2 Cosimo Cecchi 2014-11-17 17:10:01 UTC 
Review of attachment 290844 [details] [review]:

Have you tried this patch? I don't think it will work, as in WebKit2 you should not pack the webview into a GtkScrolledWindow anymore.

::: src/js/viewers/html.js
@@ +30,3 @@
 const Sushi = imports.gi.Sushi;
 
+const Lang = imports.lang;

Doesn't look like you use this.
Comment 3 Marcos Chavarria Teijeiro 2014-11-18 08:26:02 UTC 
Created attachment 290894 [details] [review]
Remove Lang declaration
Comment 4 Marcos Chavarria Teijeiro 2014-11-18 09:38:32 UTC 
(In reply to comment #2)
> Review of attachment 290844 [details] [review]:
> 
> Have you tried this patch? I don't think it will work, as in WebKit2 you should
> not pack the webview into a GtkScrolledWindow anymore.

Ups, I have just read this comment and yes, I have tried it or at least I think I did it... And it worked.

> 
> ::: src/js/viewers/html.js
> @@ +30,3 @@
>  const Sushi = imports.gi.Sushi;
> 
> +const Lang = imports.lang;
> 
> Doesn't look like you use this.
Comment 5 Marcos Chavarria Teijeiro 2014-11-18 10:19:36 UTC 
Created attachment 290899 [details] [review]
Patch

Remove scrolled window.
Comment 6 Cosimo Cecchi 2014-11-20 17:41:42 UTC 
Thanks, I pushed this with a slight change to the WebkitWebView constructor syntax.