After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740235 - glcontext: build errors when GST_GL_HAVE_OPENGL is 0
glcontext: build errors when GST_GL_HAVE_OPENGL is 0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal major
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-17 04:06 UTC by Vineeth
Modified: 2014-11-18 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix build errors (1.66 KB, patch)
2014-11-17 04:07 UTC, Vineeth
committed Details | Review

Description Vineeth 2014-11-17 04:06:37 UTC
When compiling gst-plugins-bad, i am getting the below build errors

gstglcontext.c: In function 'gst_gl_context_get_current_gl_api':
gstglcontext.c:493:14: error: unused variable 'context_flags' [-Werror=unused-variable]
       GLuint context_flags = 0;
              ^
gstglcontext.c:448:10: error: variable 'GetIntegerv' set but not used [-Werror=unused-but-set-variable]
   void (*GetIntegerv) (GLenum name, GLuint * n);


This is happening because OpenGL is not present in my PC.

Moving variables within #if GST_GL_HAVE_OPENGL, for all those variables
Comment 1 Vineeth 2014-11-17 04:07:42 UTC
Created attachment 290831 [details] [review]
fix build errors
Comment 2 Matthew Waters (ystreet00) 2014-11-17 11:40:23 UTC
commit aafc0d509c697e5e9778e40a1e9adc54e3cc60e5
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Mon Nov 17 09:36:52 2014 +0530

    glcontext: build errors when GST_GL_HAVE_OPENGL is 0
    
    Moving variables within #if GST_GL_HAVE_OPENGL, which are not going to be used otherwise.
    and which are needed only when OpenGl is present
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740235
Comment 3 Luis de Bethencourt 2014-11-18 17:21:05 UTC
Thanks Matthew! :)