After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740227 - network: properly remove connections from list
network: properly remove connections from list
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 740229
 
 
Reported: 2014-11-16 23:53 UTC by Allison Karlitskaya (desrt)
Modified: 2014-11-26 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: properly remove connections from list (1.23 KB, patch)
2014-11-16 23:53 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-11-16 23:53:51 UTC 
Due to a typo we were always removing the first (index 0) connection
from the global list of connections instead of the correct one.

This resulted in some connections remaining in the shell's connection
list long after they were removed.  In particular, this resulted in
multiple copies of a bluetooth connection appearing after suspend/resume
(when the device was readded and the cached connection list was
rescanned).
Comment 1 Allison Karlitskaya (desrt) 2014-11-16 23:53:55 UTC 
Created attachment 290818 [details] [review]
network: properly remove connections from list
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-11-17 00:19:58 UTC 
Review of attachment 290818 [details] [review]:

Whoops, nice catch.
Comment 3 Allison Karlitskaya (desrt) 2014-11-17 08:35:18 UTC 
Attachment 290818 [details] pushed as 3d4408d - network: properly remove connections from list
Comment 4 Dan Winship 2014-11-19 20:53:28 UTC 
FWIW, this bug is in 3.12 too, and it can cause gnome-shell to crash when you restart NetworkManager or add a new network device. Eg, in F20: connect to VPN, disconnect from VPN, plug in WWAN dongle, boom!
Comment 5 Allison Karlitskaya (desrt) 2014-11-19 22:32:10 UTC 
A backport might indeed be nice from the standpoint of getting this into various distro releases...
Comment 6 Dan Williams 2014-11-21 20:17:38 UTC 
Cherry-picked to gnome-3-12 and gnome-3-10
Comment 7 Allison Karlitskaya (desrt) 2014-11-26 21:17:16 UTC 
Also to gnome-3-14 now.