After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740172 - 'atk_focus_tracker_notify' is deprecated
'atk_focus_tracker_notify' is deprecated
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-15 14:38 UTC by Magdalen Berns (irc magpie)
Modified: 2015-02-27 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to address problem (744 bytes, patch)
2014-11-17 19:02 UTC, Magdalen Berns (irc magpie)
needs-work Details | Review
Patch to address problem (795 bytes, patch)
2014-11-18 12:37 UTC, Magdalen Berns (irc magpie)
committed Details | Review

Description Magdalen Berns (irc magpie) 2014-11-15 14:38:36 UTC
This is used in AtkWrapper.c.

Not sure what to use instead yet because warning message does not indicate what alternative might be.
Comment 1 Magdalen Berns (irc magpie) 2014-11-15 14:40:56 UTC
Seems like it has been dropped altogether:

https://developer.gnome.org/atk/unstable/AtkUtil.html#atk-focus-tracker-notify
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-11-17 13:55:14 UTC
I just extended the deprecation section on atk_focus_tracker_notify documentation:
https://git.gnome.org/browse/atk/commit/?id=89e2790f3e94de24cbabd55f211800054dcc81a1
Comment 3 Magdalen Berns (irc magpie) 2014-11-17 16:04:49 UTC
Thanks for that! I'll update the wrapper accordingly.
Comment 4 Magdalen Berns (irc magpie) 2014-11-17 19:02:52 UTC
Created attachment 290875 [details] [review]
Patch to address problem

Question: Should I be doing something with object selected here too?
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-11-18 12:11:26 UTC
Review of attachment 290875 [details] [review]:

(In reply to comment #4)
> Created an attachment (id=290875) [details] [review]
> Patch to address problem
> 
> Question: Should I be doing something with object selected here too?

I don't think so. Focus changes and selection changes are different events. So if this is a handler to notify focus changes, just focus changes should be forwarded.

::: jni/src/AtkWrapper.c
@@ +288,2 @@
   AtkObject* atk_obj = ATK_OBJECT(jaw_impl);
+  atk_object_notify_state_change(atk_obj, ATK_STATE_FOCUSED, FALSE);

The old code was notifying when atk_obj got the focus, to this state-change::focused should be with a TRUE, not with a FALSE.
Comment 6 Magdalen Berns (irc magpie) 2014-11-18 12:16:43 UTC
(In reply to comment #5)
> Review of attachment 290875 [details] [review]:
> 
> (In reply to comment #4)
> > Created an attachment (id=290875) [details] [review] [details] [review]
> > Patch to address problem
> > 
> > Question: Should I be doing something with object selected here too?
> 
> I don't think so. Focus changes and selection changes are different events. So
> if this is a handler to notify focus changes, just focus changes should be
> forwarded.
> 
> ::: jni/src/AtkWrapper.c
> @@ +288,2 @@
>    AtkObject* atk_obj = ATK_OBJECT(jaw_impl);
> +  atk_object_notify_state_change(atk_obj, ATK_STATE_FOCUSED, FALSE);
> 
> The old code was notifying when atk_obj got the focus, to this
> state-change::focused should be with a TRUE, not with a FALSE.

Ok thanks for the review. I'll update it accordingly.
Comment 7 Magdalen Berns (irc magpie) 2014-11-18 12:37:39 UTC
Created attachment 290903 [details] [review]
Patch to address problem

Ok I have committed this change.
Comment 8 André Klapper 2015-02-27 16:58:40 UTC
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]