GNOME Bugzilla – Bug 740172
'atk_focus_tracker_notify' is deprecated
Last modified: 2015-02-27 16:58:40 UTC
This is used in AtkWrapper.c. Not sure what to use instead yet because warning message does not indicate what alternative might be.
Seems like it has been dropped altogether: https://developer.gnome.org/atk/unstable/AtkUtil.html#atk-focus-tracker-notify
I just extended the deprecation section on atk_focus_tracker_notify documentation: https://git.gnome.org/browse/atk/commit/?id=89e2790f3e94de24cbabd55f211800054dcc81a1
Thanks for that! I'll update the wrapper accordingly.
Created attachment 290875 [details] [review] Patch to address problem Question: Should I be doing something with object selected here too?
Review of attachment 290875 [details] [review]: (In reply to comment #4) > Created an attachment (id=290875) [details] [review] > Patch to address problem > > Question: Should I be doing something with object selected here too? I don't think so. Focus changes and selection changes are different events. So if this is a handler to notify focus changes, just focus changes should be forwarded. ::: jni/src/AtkWrapper.c @@ +288,2 @@ AtkObject* atk_obj = ATK_OBJECT(jaw_impl); + atk_object_notify_state_change(atk_obj, ATK_STATE_FOCUSED, FALSE); The old code was notifying when atk_obj got the focus, to this state-change::focused should be with a TRUE, not with a FALSE.
(In reply to comment #5) > Review of attachment 290875 [details] [review]: > > (In reply to comment #4) > > Created an attachment (id=290875) [details] [review] [details] [review] > > Patch to address problem > > > > Question: Should I be doing something with object selected here too? > > I don't think so. Focus changes and selection changes are different events. So > if this is a handler to notify focus changes, just focus changes should be > forwarded. > > ::: jni/src/AtkWrapper.c > @@ +288,2 @@ > AtkObject* atk_obj = ATK_OBJECT(jaw_impl); > + atk_object_notify_state_change(atk_obj, ATK_STATE_FOCUSED, FALSE); > > The old code was notifying when atk_obj got the focus, to this > state-change::focused should be with a TRUE, not with a FALSE. Ok thanks for the review. I'll update it accordingly.
Created attachment 290903 [details] [review] Patch to address problem Ok I have committed this change.
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]