After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740152 - Deprecate STATE_ARMED
Deprecate STATE_ARMED
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-15 01:03 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-11-20 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (3.27 KB, patch)
2014-11-19 20:56 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-11-15 01:03:28 UTC
+++ This bug was initially created as a clone of Bug #398100 +++

STATE_ARMED is useless. Given that we're actively working on ATK's API, let's add deprecating it for this cycle.
Comment 1 Joanmarie Diggs (IRC: joanie) 2014-11-19 20:56:09 UTC
Created attachment 291036 [details] [review]
Proposed patch

This just updates the documentation, which looking at this similar case [1], is the way to go. Once it's documented, we can then inform implementors to stop using it.

[1] https://git.gnome.org/browse/atk/commit/?id=26b34d0d
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-11-20 11:19:25 UTC
Review of attachment 291036 [details] [review]:

LGTM. Thanks.
Comment 3 Joanmarie Diggs (IRC: joanie) 2014-11-20 13:41:52 UTC
Comment on attachment 291036 [details] [review]
Proposed patch

Thanks!

https://git.gnome.org/browse/atk/commit/?id=13e3fd39