After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740141 - A few cancel button fixes
A few cancel button fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-14 20:31 UTC by Ray Strode [halfline]
Modified: 2014-11-17 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdm: disallow cancel after verification succeeds (6.31 KB, patch)
2014-11-14 20:31 UTC, Ray Strode [halfline]
committed Details | Review
gdm: fix sensitivity of auth prompt when cancelling early and user list is disabled (4.21 KB, patch)
2014-11-14 20:31 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2014-11-14 20:31:39 UTC
I did these for RHEL and am upstreaming them.
Comment 1 Ray Strode [halfline] 2014-11-14 20:31:42 UTC
Created attachment 290732 [details] [review]
gdm: disallow cancel after verification succeeds

Once verification has succeeded, the train's already
left the building and we shouldn't allow canceling.

This commit renders the cancel button non-reactive
and makes the cancel function be a noop after
verification succeeds.
Comment 2 Ray Strode [halfline] 2014-11-14 20:31:47 UTC
Created attachment 290733 [details] [review]
gdm: fix sensitivity of auth prompt when cancelling early and user list is disabled

If the user list is disabled and the user clicks cancel quickly enough
after typing their username, they can get in a state where the
auth prompt gets stuck in the insensitive state.

This is because the login dialog code makes the prompt insensitive
while while pam is processing the provided username, but the prompt
only makes itself sensitive again when it is hidden.

This commit makes it sensitive right before asking for a username again.
Comment 3 drago01 2014-11-16 14:15:45 UTC
Review of attachment 290732 [details] [review]:

OK.
Comment 4 drago01 2014-11-16 14:16:30 UTC
Review of attachment 290733 [details] [review]:

OK.
Comment 5 Ray Strode [halfline] 2014-11-17 17:11:02 UTC
Attachment 290732 [details] pushed as 5d440fa - gdm: disallow cancel after verification succeeds
Attachment 290733 [details] pushed as 5961f16 - gdm: fix sensitivity of auth prompt when cancelling early and user list is disabled