After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740074 - shellDBus: don't consider a zero-index monitor invalid
shellDBus: don't consider a zero-index monitor invalid
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 704086
 
 
Reported: 2014-11-13 18:05 UTC by Cosimo Cecchi
Modified: 2014-11-13 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shellDBus: don't consider a zero-index monitor invalid (964 bytes, patch)
2014-11-13 18:06 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-11-13 18:05:57 UTC 
See patch. This blocks bug 704086.
Comment 1 Cosimo Cecchi 2014-11-13 18:06:07 UTC 
Created attachment 290650 [details] [review]
shellDBus: don't consider a zero-index monitor invalid

Currently, shellDBus only uses the passed in monitor index if it's
strictly > 0. A zero-index monitor is a valid one though, so don't
restrict this to strictly positive indices.
Comment 2 Florian Müllner 2014-11-13 18:09:34 UTC 
Review of attachment 290650 [details] [review]:

Sure
Comment 3 Cosimo Cecchi 2014-11-13 18:15:47 UTC 
Thanks for the quick review.

Attachment 290650 [details] pushed as 45e42d7 - shellDBus: don't consider a zero-index monitor invalid