After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739930 - Port server-alsasrc-PCMA.py to version 1.x
Port server-alsasrc-PCMA.py to version 1.x
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-10 22:01 UTC by Henning Heinold
Modified: 2014-11-17 00:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (5.55 KB, patch)
2014-11-11 07:55 UTC, Henning Heinold 		accepted-commit_now Details | Review
update of the PCMA test (11.72 KB, patch)
2014-11-12 19:50 UTC, Henning Heinold 		none Details | Review
added sys.argv to the patch (11.75 KB, patch)
2014-11-13 00:57 UTC, Henning Heinold 		committed Details | Review

Description Henning Heinold 2014-11-10 22:01:37 UTC 
Hi,

I followed the python gstreamer porting guide and ported
tests/examples/rtp/server-alsasrc-PCMA.py
to versionx 1.x
Comment 1 Olivier Crête 2014-11-10 22:22:33 UTC 
You seem to have not attached your ported version.
Comment 2 Olivier Crête 2014-11-10 22:22:58 UTC 
client-PCMA.py also needs ported if you feel like it!
Comment 3 Henning Heinold 2014-11-11 07:55:47 UTC 
Created attachment 290397 [details] [review]
Patch
Comment 4 Henning Heinold 2014-11-11 07:56:56 UTC 
Sorry, I thought bugzilla can do it one go. Now the patch is attached. I will look at the client too.
Comment 5 Olivier Crête 2014-11-11 17:48:47 UTC 
Review of attachment 290397 [details] [review]:

Looks good

::: tests/examples/rtp/server-alsasrc-PCMA.py
@@ +69,3 @@
+sinkpad = Gst.Element.get_request_pad(rtpbin, 'send_rtp_sink_0')
+srcpad = Gst.Element.get_static_pad(audiopay, 'src')
+lres = Gst.Pad.link(srcpad, sinkpad)

I wonder why we didn't do srcpad.link(sinkpad) here
Comment 6 Henning Heinold 2014-11-12 19:50:04 UTC 
Hi,

I have updated the patch and includes the client now too. I tested both and it seems to work. I can at least hear the testsound.
Comment 7 Henning Heinold 2014-11-12 19:50:58 UTC 
Created attachment 290543 [details] [review]
update of the PCMA test
Comment 8 Olivier Crête 2014-11-12 21:02:03 UTC 
Review of attachment 290543 [details] [review]:

::: tests/examples/rtp/client-PCMA.py
@@ +36,3 @@
+
+GObject.threads_init()
+Gst.init(None)

Gst.init(sys.argv)

::: tests/examples/rtp/server-alsasrc-PCMA.py
@@ +22,3 @@
+
+GObject.threads_init()
+Gst.init(None)

Same here
Comment 9 Henning Heinold 2014-11-13 00:57:17 UTC 
Created attachment 290568 [details] [review]
added sys.argv to the patch
Comment 10 Tim-Philipp Müller 2014-11-17 00:24:58 UTC 
Pushed, thanks for the patch!

commit 8aa263006865584b5dcc05378d18ff052e6f188e
Author: Henning Heinold <henning@itconsulting-heinold.de>
Date:   Mon Nov 10 22:34:39 2014 +0100

    examples: port python rtp PCMA client/server tests to 1.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739930